Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #396 #403

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Fix #396 #403

merged 4 commits into from
Aug 19, 2024

Conversation

1letter
Copy link
Contributor

@1letter 1letter commented Aug 14, 2024

change imports of some widgets to plone.app.z3cform, make widget bootstrap 5 ready

@mister-roboto
Copy link

@1letter thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@1letter
Copy link
Contributor Author

1letter commented Aug 14, 2024

@jenkins-plone-org please run jobs

@1letter
Copy link
Contributor Author

1letter commented Aug 14, 2024

@jenkins-plone-org please run jobs

@1letter 1letter requested a review from thet August 18, 2024 14:29
# TextLinesFieldWidget is introduced in plone.app.z3cform==4.4.0
from z3c.form.browser.textlines import TextLinesFieldWidget
except ImportError:
from z3c.form.browser.textlines import TextLinesFieldWidget
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same import after ImportError

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry... i updated the import snippet and started the tests

@1letter
Copy link
Contributor Author

1letter commented Aug 19, 2024

@jenkins-plone-org please run jobs

Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge when green 👍🏼

@1letter 1letter merged commit 0d2079c into master Aug 19, 2024
14 checks passed
@1letter 1letter deleted the fix-#396 branch August 19, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants