Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix calendar portlet to work when selected item is a Collection #400

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Fix calendar portlet to work when selected item is a Collection #400

merged 5 commits into from
Jul 24, 2024

Conversation

erral
Copy link
Member

@erral erral commented Jul 18, 2024 •
edited
Loading

Fixes #399

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

stevepiercy
stevepiercy previously requested changes Jul 18, 2024
View reviewed changes
plone/app/event/portlets/portlet_calendar.py Outdated Show resolved Hide resolved
@erral erral force-pushed the erral-issue-399 branch from 09b2f9e to 33a4edc Compare July 22, 2024 09:46
@erral erral changed the title add tests Fix calendar portlet to work when selected item is a Collection Jul 22, 2024
@erral erral marked this pull request as ready for review July 22, 2024 09:53
@erral
Copy link
Member Author

erral commented Jul 22, 2024

@jenkins-plone-org please run jobs

stevepiercy
stevepiercy reviewed Jul 22, 2024
View reviewed changes
Copy link

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a sanity check question. Otherwise LGTM, but this should be reviewed by someone else who has more familiarity with the code than I. Would you please request from other reviewers?

plone/app/event/portlets/portlet_calendar.py Show resolved Hide resolved
@stevepiercy stevepiercy requested a review from thet July 22, 2024 10:43
@stevepiercy stevepiercy dismissed their stale review July 22, 2024 10:43

Passed triage

@davisagli davisagli merged commit 3608882 into master Jul 24, 2024
14 checks passed
@davisagli davisagli deleted the erral-issue-399 branch July 24, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy left review comments

@davisagli davisagli davisagli approved these changes

@thet thet Awaiting requested review from thet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calendar portlet breaks when selecting a Collection with date restriction as a source
4 participants
@erral @mister-roboto @davisagli @stevepiercy