Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more hints for new contributors #162

Merged
merged 5 commits into from
Sep 21, 2024
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/mr.roboto/src/mr/roboto/subscriber.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ def check_membership(self, json_data):
class ContributorsAgreementSigned(PullRequestSubscriber):
def __init__(self, event):
self.cla_url = "https://plone.org/foundation/contributors-agreement" # noqa
self.cla_email = "[email protected]"
self.github_help_setup_email_url = "https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account" # noqa
self.status_context = "Plone Contributors Agreement verifier"

Expand Down Expand Up @@ -248,8 +249,17 @@ def run(self):
users = " @".join(not_foundation)
msg = (
f"@{users} you need to sign the Plone Contributor "
f"Agreement to merge this pull request. \n\n"
"Agreement to merge this pull request."
"\n\n"
f"Learn about the Plone Contributor Agreement: {self.cla_url}"
"\n\n"
"If you have already signed the agreement, "
"please allow a week for your agreement to be processed.\n"
"Once it is processed, you will receive an email invitation "
"to join the `plone` GitHub organization as a Contributor."
"\n\n"
"If after a week, you have not received an invitation, then "
f"please contact {self.cla_email}."
)
self.g_issue.create_comment(body=msg)

Expand All @@ -266,6 +276,11 @@ def run(self):
f"Learn about the Plone Contributor Agreement: {self.cla_url} "
f"How to add more emails to your GitHub account: "
f"{self.github_help_setup_email_url} "
"\n\n"
"If you have sent in your Plone Contributor Agreement, "
"and received an invitation to join the Plone GitHub organization, "
"but your emails are not known, then you might need to add "
"the email address on your Agreement to your GitHub account."
)
self.g_issue.create_comment(body=msg)

Expand Down
Loading