Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how to use Google Translate to translate content #1723

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

erral
Copy link
Member

@erral erral commented Sep 29, 2024

Wait for plone/plone.app.multilingual#462 and plone/plone.app.multilingual#463 to be merged, they fix how this works in Plone 6.


📚 Documentation preview 📚: https://plone6--1723.org.readthedocs.build/

@erral erral requested a review from stevepiercy September 29, 2024 14:40
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you! Will merge when green.

@erral
Copy link
Member Author

erral commented Sep 30, 2024

Please, wait until the referenced PRs are merged. They fix the working of the translation system.

@stevepiercy
Copy link
Contributor

@erral gotcha. I'll let you do the honors of merging.

@erral
Copy link
Member Author

erral commented Oct 7, 2024

@stevepiercy I can't merge this. You can proceed because the referenced PRs are already merged.

@stevepiercy
Copy link
Contributor

@erral that's odd. If you can write to the repo, creating a new branch and pushing commits, you should be able to merge the PR. I'll go ahead.

@stevepiercy stevepiercy merged commit 41696ab into 6.0 Oct 7, 2024
3 checks passed
@stevepiercy stevepiercy deleted the erral-how-to-use-google-translate branch October 7, 2024 11:08
@erral
Copy link
Member Author

erral commented Oct 7, 2024

@erral that's odd. If you can write to the repo, creating a new branch and pushing commits, you should be able to merge the PR. I'll go ahead.

Yeah, it said that I wasn't authorized to merge the PR.

Is it perhaps because I created it?

@stevepiercy
Copy link
Contributor

I don't think that would be it. It's OK for creators to merge their own PRs.

As a member of the Plone Developers Team, you have write access to this repo. Do you have two different logins for GitHub?

If it happens again, can you post a screenshot of what you see?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants