Fix acknowledge abuse download of unflagged files #410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the
--acknowledge-abuse
flag is given, plexdrive can only download abused files, files not flagged for abuse fail to download with the error "invalidAbuseAcknowledoment".This PR tries to fix that by only adding the
acknowledgeAbuse=true
parameter to the download URL, if the--acknowledge-abuse
was given and the download request failed with the "cannotDownloadAbusiveFile" error.The drawback is that we do twice as many download requests for abused files, but a better solution would require to cache the abuse state of a file in the drive object metadata inside cache.bolt, which would require a lot more code changes.
Unrelated to the fix I've also moved the global acknowledgeAbuse option flag to be passed directly to the Downloader instance, instead of repeating it in each Request struct.