Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] Patch updates #884

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

scala-steward
Copy link
Contributor

About this PR

Updates:

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add these to your .scala-steward.conf file to ignore future updates of these dependencies:

updates.ignore = [
  { groupId = "ch.epfl.scala", artifactId = "sbt-bloop" },
  { groupId = "org.scala-lang", artifactId = "scala-compiler" },
  { groupId = "org.scala-lang", artifactId = "scala-library" },
  { groupId = "org.scala-sbt", artifactId = "sbt" },
  { groupId = "org.scala-sbt", artifactId = "scripted-plugin" },
  { groupId = "org.scalameta", artifactId = "sbt-scalafmt" },
  { groupId = "org.scalameta", artifactId = "scalafmt-core" }
]

Or, add these to slow down future updates of these dependencies:

dependencyOverrides = [
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "ch.epfl.scala", artifactId = "sbt-bloop" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-lang", artifactId = "scala-compiler" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-lang", artifactId = "scala-library" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-sbt", artifactId = "sbt" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-sbt", artifactId = "scripted-plugin" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scalameta", artifactId = "sbt-scalafmt" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
  }
]
labels: sbt-plugin-update, test-library-update, library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, commit-count:n:7

@mergify mergify bot added the type:updates label Jan 19, 2025
@@ -117,7 +117,7 @@ object Helper {
}
}

given Context = rootCtx.fresh
given.Context = rootCtx.fresh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kitbellew Looks like scalafmt has a bug.

[error] -- [E040] Syntax Error: /home/runner/work/twirl/twirl/compiler/src/test/scala-3/play/twirl/compiler/test/Helper.scala:120:13 
[error] 120 |        given.Context = rootCtx.fresh
[error]     |             ^
[error]     |             an identifier expected, but '.' found

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurz nope. your configuration has a bug.

@mkurz mkurz force-pushed the update/2.0.x/patches branch from 0bc1539 to 65b46e7 Compare January 20, 2025 08:13
@mergify mergify bot merged commit f03a082 into playframework:2.0.x Jan 20, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants