Remove now superfluous props.path for '404' and 'WP Form Completions' #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! When will the changes related to this PR go live? |
The PR plausible/analytics#5559 is live since about July 14th. The previous approach also still works, but in the docs, we now share the new approach: https://plausible.io/docs/error-pages-tracking-404#step-3-paste-this-piece-of-code-to-your-404-page-template |
|
Good to know. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is meant to show that setting props.path is not needed for special goals '404' and 'WP Form Completions' after plausible/analytics#5559. It is automatically synced to be the same as the resolved pathname of the event (if it is not set explicitly in the tracking request).
There's no particular hurry with merging this change. Anyone currently tracking these events with props.path set will keep seeing exactly what they're seeing right now.
There's a slight serialization difference between event.pathname and some values of event.props.path, so it might be wise to introduce these changes in a major version change.