Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bamboo_postmark to fork repository #2477

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Update bamboo_postmark to fork repository #2477

merged 2 commits into from
Nov 29, 2022

Conversation

vinibrsl
Copy link
Contributor

This commit updates mix.exs to resolve bamboo_postmark to our fork. The fork encodes names with quotes when building e-mails, adding support for special names with commas and quotes. Related to plausible/bamboo_postmark#1.

Closes #1885

@vinibrsl vinibrsl requested a review from a team November 28, 2022 20:10
@bundlemon
Copy link

bundlemon bot commented Nov 28, 2022

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
515.19KB -
static/js/dashboard.js
297.99KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
748B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

This commit updates mix.exs to resolve bamboo_postmark to our fork.
The fork encodes names with quotes when building e-mails, adding support
for special names with commas and quotes. Related to
plausible/bamboo_postmark#1.

Closes #1885
@ukutaht
Copy link
Contributor

ukutaht commented Nov 29, 2022

Looks good to me! One small request: Can you add a note to the fork readme that explains
a) That it's a fork of the original
b) Why we forked it

I've lost track of the why on some of the forks I've done in the past. I think it's important to record it.

@spapas
Copy link
Contributor

spapas commented Nov 29, 2022

Hey friends, you've added the {:bamboo_postmark, git: "https://github.com/plausible/bamboo_postmark.git", tag: "main"}, line in mix.exs but there's no main tag on that repo (actually there are no tags)... I had to remove the tag from there to be able to get the deps on my system.

@vinibrsl
Copy link
Contributor Author

Hey friends, you've added the {:bamboo_postmark, git: "https://github.com/plausible/bamboo_postmark.git", tag: "main"}, line in mix.exs but there's no main tag on that repo (actually there are no tags)... I had to remove the tag from there to be able to get the deps on my system.

Thanks for catching that! I meant branch instead of tag. Fixed in 991740c.

@vinibrsl
Copy link
Contributor Author

Looks good to me! One small request: Can you add a note to the fork readme that explains a) That it's a fork of the original b) Why we forked it

I've lost track of the why on some of the forks I've done in the past. I think it's important to record it.

Good call! https://github.com/plausible/bamboo_postmark#fork

@aerosol
Copy link
Member

aerosol commented Nov 29, 2022

Ref pablo-co/bamboo_postmark#32

@ukutaht ukutaht merged commit 96182da into master Nov 29, 2022
@ukutaht ukutaht deleted the postmark-fork branch November 29, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account registration form issue with comma in the name
4 participants