Hardening: explicit jwt secret #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit 127e0d4. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
🔮 Deploy Preview for rxdb-jmespath-demo canceled.
|
🔮 Deploy Preview for platyplus canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will turn an explicitly supplied jwtSecret into an environment variable (not a secret). The value can be specified as string, but also as a more readable yaml object. Making it a "public" value should not be a big issue, as using custom jwtSecret would likely mean that an auth service is being used, so no private bits are present at HASURA_GRAPHQL_JWT_SECRET (at least in our case happens in that way).