Add esp32 like embed_files support for arduino framework #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToMe25
added a commit
to ToMe25/ESP-WakeOnLan
that referenced
this pull request
Feb 1, 2022
Should fully work except for IPv6 address printing. Requires platformio/platform-espressif8266#267 to build. Updating using OTA on ESP8266 causes an exception, but that seems to be a general problem with mDNS. It still works, it just spams the Serial console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a esp32 like
embed_filesandembed_txtfilesplatformio.ini option._embed_files.py is a very lightly modified copy of esp32 _embed_files.py.
This PR currently only adds embed_files support for the arduino framework because that is the only one I already had a workspace for, and thus the only one I can test easily.
It would be a tiny change to also add support to
esp8266-nonos-sdkandesp8266-rtos-sdk, so if my inability to test that well isn't an issue feel free to tell me to add that.