Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Inkplate boards #698

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nitko12
Copy link

@nitko12 nitko12 commented Jan 4, 2022

Hi, what's the procedure for adding boards to platform, is a PR here enough?

I'll be publishing a library soon hopefully :)

@rafaelmagu
Copy link

Any updates on this?

@johndbritton
Copy link

I was able to use these definitions in my project by dropping them in the boards directory, but it'd be nice for this to get merged. @valeros Does this need something more?

@valeros
Copy link
Member

valeros commented May 24, 2023

It's highly desirable that these boards are added to the official Arduino core for ESP32 https://github.com/espressif/arduino-esp32 with proper variant files.

"ldscript": "esp32_out.ld"
},
"core": "esp32",
"extra_flags": "-DARDUINO_INKPLATE6COLOR -DBOARD_HAS_PSRAM -mfix-esp32-psram-cache-issue",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is -DARDUINO_INKPLATE6COLOR correct, or should it be -DARDUINO_INKPLATECOLOR (without the 6)?

The Arduino examples all check for the define without the 6.

https://github.com/SolderedElectronics/Inkplate-Arduino-library/blob/3f1908e3cda550b156e3e5b8adeb41177a456f9e/examples/Inkplate6COLOR/Basic/Inkplate6COLOR_Full_Screen_Colors/Inkplate6COLOR_Full_Screen_Colors.ino#L16

I also can't find any reference to the define with the 6 in Inkplate-Arduino-Library, whereas it references the one without the 6 a bunch.

https://github.com/SolderedElectronics/Inkplate-Arduino-library/blob/3f1908e3cda550b156e3e5b8adeb41177a456f9e/src/Inkplate.h#L124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants