Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ESP32-H2 and ESP32-C2 #1347

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

luar123
Copy link

@luar123 luar123 commented Apr 4, 2024

This PR adds support for ESP32 H2 and C2 variants on esp-idf only.

@luar123
Copy link
Author

luar123 commented Apr 6, 2024

I just found out there is already a PR for the C2 variant. As my PR is also based on the work from Jason2866 these two are very similar, just with the added H2 variant here. So maybe first merge #1203 and then I can rebase?

@Hedda
Copy link

Hedda commented Apr 8, 2024

I just found out there is already a PR for the C2 variant. As my PR is also based on the work from Jason2866 these two are very similar, just with the added H2 variant here. So maybe first merge #1203 and then I can rebase?

@valeros should this PR maybe be changed to only include ESP32-H2 or close this PR and create a new PR for only ESP32-H2?

@Jason2866
Copy link
Contributor

For me it is fine if my PR is closed in favour of this one. Let's hope something gets merged.

@lboue
Copy link

lboue commented Apr 14, 2024

Could you please validate this?

@lboue
Copy link

lboue commented Apr 22, 2024

Could you please tell me what is missing or validate this request?

@mknjc
Copy link

mknjc commented May 5, 2024

@valeros is there anything the community could do to help merging this request?

@lboue
Copy link

lboue commented May 17, 2024

Could you validate this request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants