PCD-649 remove region'\''s default value and make it compulsory #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Review Agent Run #cc9d18Actionable Suggestions - 0Review Details
AI Code Review powered by |
poojaghumre
requested changes
Feb 4, 2025
| @@ -339,11 +339,11 @@ func ConfigCmdCreateRun(cfg *objects.Config) error { | |||
| proxyURL, _ = reader.ReadString('\n') | |||
| cfg.ProxyURL = strings.TrimSpace(proxyURL) | |||
| } | |||
|
|
|||
| /* Removing Default Region. | |||
|
Putting this on hold as its modifying the base pf9ctl and not just cloud-ctl for PCD multi-region usecase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE(S):
PCD-649
SUMMARY
Region Name defaulted to "RegionOne" before, now no default its a mandatory feild.
ISSUE TYPE
IMPACTED FEATURES/COMPONENTS:
cloud-ctl
RELATED ISSUE(S):
DEPENDS ON:
TESTING DONE
Automated
Manual
Inprogress
Reviewers
Summary by Bito
Removed default 'RegionOne' value from configuration system, making region specification mandatory for users. Updated region prompt messaging and documentation to reflect this change. This modification enforces explicit region selection rather than relying on default values.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1