Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the go version in Makefile to 1.18 #395

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

bharath-pf9
Copy link
Contributor

@bharath-pf9 bharath-pf9 commented Jan 9, 2025

Testing to see If the version is something that's causing pf9ctl not work properly.

Output that we get when testing with latest pf9ctl,

* Connection #0 to host pmkft-assets.s3.us-west-1.amazonaws.com left intact
/root/pf9/bin/pf9ctl_new: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /root/pf9/bin/pf9ctl_new)
/root/pf9/bin/pf9ctl_new: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /root/pf9/bin/pf9ctl_new)
16:14:37.694003794 :63 : ASSERT: Installation of Platform9 CLI Failed

With this change, pf9ctl install works fine.

Making an additional change to match regex with double digits e.g., to match '8.10'

@bharath-pf9 bharath-pf9 added the hold merging Do not merge this PR label Jan 9, 2025
@bharath-pf9 bharath-pf9 merged commit e64dceb into master Jan 15, 2025
4 checks passed
@bharath-pf9 bharath-pf9 deleted the private/bharath/change_go_version_in_makefile branch January 15, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants