Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMK-6577 fix hostagent env #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

srm6867
Copy link
Contributor

@srm6867 srm6867 commented Oct 14, 2024

ISSUE(S):

https://platform9.atlassian.net/browse/PMK-6577

ISSUE TYPE

  • Bug fix (non-breaking change which fixes an issue)
    expected)

TESTING DONE

Manual

Pending

Reviewers

Copy link
Contributor

@cruizen cruizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cruizen
Copy link
Contributor

cruizen commented Jan 23, 2025

Can you review @psarwate , @jayanth-tjvrr ?
Can you add testing details @srm6867 ?

@cruizen cruizen requested review from mridulgain and removed request for vedantjoshi84 February 20, 2025 07:02
Copy link

@mridulgain mridulgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mridulgain
Copy link

Verified locally with

ubuntu@mridul-dev-vm:~/pf9ctl$ ./bin/pf9ctl set-proxy --protocol http --host-ip 10.85.10.99 --port 8080 --no-proxy 127.0.0.1,localhost,::1,bud2-otp-k8svip.sambanova.local,.svc,.svc.cluster.local,10.21.0.0/16,10.20.0.0/16,.cluster.local,10.85.10.0/24,10.85.11.0/24
New version found. Please upgrade to the latest version
2025-02-20T08:24:02.4312Z       INFO    Adding proxy setting to /opt/pf9/hostagent/pf9-hostagent.env
2025-02-20T08:24:02.5034Z       INFO    pf9-hostagent proxy setting added to /opt/pf9/hostagent/pf9-hostagent.env 
2025-02-20T08:24:02.5034Z       INFO    Adding proxy setting to /etc/pf9/comms_proxy_cfg.json 
2025-02-20T08:24:02.6557Z       INFO    pf9-comms proxy settng added to /etc/pf9/comms_proxy_cfg.json 
2025-02-20T08:24:02.7273Z       INFO    Changed ownership of /etc/pf9/comms_proxy_cfg.json file to pf9:pf9group
2025-02-20T08:24:02.7273Z       INFO    Restarting Platform9 services
2025-02-20T08:24:02.8346Z       INFO    pf9-hostagent is restarted
2025-02-20T08:24:02.9493Z       INFO    pf9-comms is restarted
ubuntu@mridul-dev-vm:~/pf9ctl$ cat /opt/pf9/hostagent/pf9-hostagent.env
PYTHONPATH="/opt/pf9/hostagent/lib/python3.6/site-packages:/opt/pf9/hostagent/lib/python3.9/site-packages/bbslave:${PYTHONPATH}"
PYTHON_EGG_CACHE=/tmp/python-eggs
LD_LIBRARY_PATH="/opt/pf9/python/pf9-lib:/opt/pf9/python/pf9-hostagent-lib:${LD_LIBRARY_PATH}"
http_proxy=http://10.85.10.99:8080
https_proxy=http://10.85.10.99:8080
HTTP_PROXY=http://10.85.10.99:8080
HTTPS_PROXY=http://10.85.10.99:8080
no_proxy=127.0.0.1,localhost,::1,bud2-otp-k8svip.sambanova.local,.svc,.svc.cluster.local,10.21.0.0/16,10.20.0.0/16,.cluster.local,10.85.10.0/24,10.85.11.0/24
NO_PROXY=127.0.0.1,localhost,::1,bud2-otp-k8svip.sambanova.local,.svc,.svc.cluster.local,10.21.0.0/16,10.20.0.0/16,.cluster.local,10.85.10.0/24,10.85.11.0/24 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants