Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TC build #380

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix TC build #380

merged 2 commits into from
Aug 6, 2024

Conversation

vedantjoshi84
Copy link
Contributor

ISSUE(S):

SUMMARY

Teamcity build was failing for pf9ctl with following error -

/tmp/pkg/mod/golang.org/x/[email protected]/http2/transport.go:1096:13: tc.NetConn undefined (type *tls.Conn has no field or method NetConn)
[18:51:48](https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9Components_Pf9ctl/3339979?showLog=3339979_192_192)
  note: module requires Go 1.18
[18:51:58](https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9Components_Pf9ctl/3339979?showLog=3339979_1266_1266)
  FAIL  github.com/platform9/pf9ctl/pkg/cloud_providers [build failed]
[18:51:58](https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9Components_Pf9ctl/3339979?showLog=3339979_1267_1267)
  FAIL  github.com/platform9/pf9ctl/pkg/pmk [build failed]
[18:51:58](https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9Components_Pf9ctl/3339979?showLog=3339979_1268_1268)
  make: *** [Makefile:48: test] Error 2
[18:52:00](https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9Components_Pf9ctl/3339979?showLog=3339979_1269_1269)
  make: *** [container-build] Error 2

Build: https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9Components_Pf9ctl/3339979

ISSUE TYPE

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that may cause existing functionality to not work as expected)
  • This change requires a documentation update

IMPACTED FEATURES/COMPONENTS:

RELATED ISSUE(S):

DEPENDS ON:

TESTING DONE

Automated

TC build after this change: https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9Components_Pf9ctl/3339987

Reviewers

srinivaschavan
srinivaschavan previously approved these changes Aug 5, 2024
@vedantjoshi84 vedantjoshi84 merged commit 8490113 into master Aug 6, 2024
4 checks passed
@vedantjoshi84 vedantjoshi84 deleted the private/vjoshi/master/fix-build branch August 6, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants