Adding new tutorial to Plasmo #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KiernanJ, thanks for your contribution! We had some issues with an old workflow. Can you try merging the latest main into your PR? It should re-trigger the checks. |
dlcole3
reviewed
Apr 2, 2025
| end | ||
| end | ||
|
|
||
| # Set initial condition for t1 |
There was a problem hiding this comment.
@KiernanJ in the end of this tutorial, you have a function called MHMPC. Can you define this function earlier in the code? I think this is essentially just these next couple lines of code (136-137) that are wrapped in a function
dlcole3
reviewed
Apr 2, 2025
| end | ||
| ``` | ||
|
|
||
| Now, plotting the values of $x$ from our program: |
There was a problem hiding this comment.
Can you add an extra empty line after line 206? In the markdown, this figure shows up on the same line as 206, and I think it would look a little better to have it below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tutorial implementation of multi-horizon MPC to Plasmo. Super simple example for beginners in optimization, JuMP, and Plasmo.