Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#383 fill undefined property columns and complete header columns #384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kirchsth
Copy link
Member

@kirchsth kirchsth commented Feb 9, 2025

related to #383

Property tables have 2 problems
a) if a column is missing then the values of the following columns are moved left too
b) if a header has less columns than the following rows the following rows are truncated too

eg. following code produces following image

@startuml
!include <C4/C4.puml>
!include <C4/C4_Container.puml>

' at b) header has only 2 columns, therefore col3 is not displayed
SetPropertyHeader("", $col2Name="2")
AddProperty($col1="col1")
AddProperty("", $col2="col2")
AddProperty(" ", " ", $col3="col3")
' at a) col4 is displayed in column 2 and not 4
AddProperty("", $col4="col4")

Container(c, "Container")
@enduml

Both problems are fixed with this MR and can be checked via my extended branch

(PlantUML >= v1.2025.1beta9 has a bugfix of b), the hidden columns based ob incomplete headers, but I still added this fix, that it works with older versions too)

BR
Helmut

@kirchsth kirchsth self-assigned this Feb 9, 2025
@kirchsth kirchsth added this to the v2.12.0 milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WithoutPropertyHeader() leads to missing "Value" column if first Property is ""
1 participant