Skip to content

Commit

Permalink
return default row height instead of a calculation for estimated heig…
Browse files Browse the repository at this point in the history
…ht (#218)

* return default row height instead of a calculation

* update changelog

* update podspec
  • Loading branch information
DerCSpringer committed Nov 3, 2023
1 parent 978a4cb commit 1c04800
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The changelog for `ReactiveLists`. Also see the [releases](https://github.com/pl

NEXT
----
0.8.2
-----
- Use default row heights for cell estimation

0.8.1.9
-----
- Added UITableViewDelegate calls for estimated row, header, footer heights
Expand Down
2 changes: 1 addition & 1 deletion ReactiveLists.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "ReactiveLists"
s.version = "0.8.1.beta.9"
s.version = "0.8.2"

s.summary = "React-like API for UITableView and UICollectionView"
s.homepage = "https://github.com/plangrid/ReactiveLists"
Expand Down
2 changes: 1 addition & 1 deletion Sources/TableViewDriver.swift
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ extension TableViewDriver: UITableViewDelegate {
/// :nodoc:
public func tableView(_ tableView: UITableView, estimatedHeightForRowAt indexPath: IndexPath) -> CGFloat {
guard let tableViewModel = self.tableViewModel else { return 0 }
return tableViewModel[ifExists: indexPath]?.rowHeight ?? tableViewModel.defaultRowHeight
return tableViewModel.defaultRowHeight
}

/// :nodoc:
Expand Down

0 comments on commit 1c04800

Please sign in to comment.