Skip to content

Conversation

@rabiejavadian
Copy link

No description provided.

Copy link

@KashishArora KashishArora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works fine

@mjbear
Copy link

mjbear commented Oct 2, 2024

Now that I'm on the correct PR for my comment. 😅

@rabiejavadian
I'm not looking to take away from your solution. (Really cool!)

Another alternative is to simply comment out the pip3 install PyYAML line and add python3-yaml to the earlier apt-get command.

RUN apt-get update && apt-get install -y \
    python3.10 \
    python3-pip \
    git \
    python3-yaml

For a temporary container a simple solution might be more desirable.

@mjbear
Copy link

mjbear commented Oct 2, 2024

@planetoftheweb
What might your preferences or thoughts be on fixing the Dockerfile?

  1. Add python3-yaml to the apt-get command?
  2. Add extra lines for a virtual environment and installing PyYAML in that venv?
    • plus having to modify the entrypoint.sh shell script

Ray Romano saying What do you think?

@mjbear
Copy link

mjbear commented Nov 10, 2024

The inclusion of pyyaml with the apt-get command means one less Docker image layer which is also a plus!
😀

https://emmer.dev/blog/reducing-docker-layers/

@planetoftheweb

@mjbear mjbear mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants