add underscore

plaidev · Aug 30, 2023 · 23326a9 · 23326a9
1 parent 8b3b321
commit 23326a9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/ios/Example/Nativebrik_Example/Nativebrik_Example/ContentView.swift b/ios/Example/Nativebrik_Example/Nativebrik_Example/ContentView.swift
@@ -131,11 +131,11 @@ Morondava is a charming coastal town located on the western coast of Madagascar.
  ScrollView(.vertical) {
  nativebrik
  .experiment
- .embedding(id: "cjjei1223akg00bptlh0")
+ .embedding("cjjei1223akg00bptlh0")
  .frame(width: nil, height: 270)
  nativebrik
  .experiment
- .remoteConfigAsView(id: "cjm5piq23akg008u0km0") { phase in
+ .remoteConfigAsView("cjm5piq23akg008u0km0") { phase in
  switch phase {
  case .failure:
  Text("error")

diff --git a/ios/Nativebrik/Classes/sdk.swift b/ios/Nativebrik/Classes/sdk.swift
@@ -193,7 +193,7 @@ public class NativebrikExperiment {
  self.overlayVC = overlay
  }
 
- public func embedding(id: String) -> some View {
+ public func embedding(_ id: String) -> some View {
  return EmbeddingSwiftView(
  experimentId: id,
  user: self.user,
@@ -204,7 +204,7 @@ public class NativebrikExperiment {
  }
 
  public func embedding<V: View>(
- id: String,
+ _ id: String,
  onEvent: ((_ event: ComponentEvent) -> Void)?,
  @ViewBuilder content: (@escaping (_ phase: AsyncComponentPhase) -> V)
  ) -> some View {
@@ -219,7 +219,7 @@ public class NativebrikExperiment {
  }
 
  public func embedding<I: View, P: View>(
- id: String,
+ _ id: String,
  onEvent: ((_ event: ComponentEvent) -> Void)?,
  @ViewBuilder content: (@escaping (_ component: any View) -> I),
  @ViewBuilder placeholder: (@escaping () -> P)
@@ -235,7 +235,7 @@ public class NativebrikExperiment {
  )
  }
 
- public func embeddingUIView(id: String) -> UIView {
+ public func embeddingUIView(_ id: String) -> UIView {
  return EmbeddingUIView(
  experimentId: id,
  user: self.user,
@@ -246,7 +246,7 @@ public class NativebrikExperiment {
  )
  }
 
- public func embeddingUIView(id: String, onEvent: ((_ event: ComponentEvent) -> Void)?) -> UIView {
+ public func embeddingUIView(_ id: String, onEvent: ((_ event: ComponentEvent) -> Void)?) -> UIView {
  return EmbeddingUIView(
  experimentId: id,
  user: self.user,
@@ -257,7 +257,7 @@ public class NativebrikExperiment {
  )
  }
 
- public func embeddingUIView(id: String, onEvent: ((_ event: ComponentEvent) -> Void)?, content: @escaping (_ phase: ComponentPhase) -> UIView) -> UIView {
+ public func embeddingUIView(_ id: String, onEvent: ((_ event: ComponentEvent) -> Void)?, content: @escaping (_ phase: ComponentPhase) -> UIView) -> UIView {
  return EmbeddingUIView(
  experimentId: id,
  user: self.user,
@@ -268,7 +268,7 @@ public class NativebrikExperiment {
  )
  }
 
- public func remoteConfig(id: String, phase: @escaping ((_ phase: RemoteConfigPhase) -> Void)) -> RemoteConfig {
+ public func remoteConfig(_ id: String, phase: @escaping ((_ phase: RemoteConfigPhase) -> Void)) -> RemoteConfig {
  return RemoteConfig(
  user: self.user,
  experimentId: id,
@@ -280,7 +280,7 @@ public class NativebrikExperiment {
  }
 
  public func remoteConfigAsView<V: View>(
- id: String,
+ _ id: String,
  @ViewBuilder phase: @escaping ((_ phase: RemoteConfigPhase) -> V)
  ) -> some View {
  return RemoteConfigAsView(