Skip to content

Conversation

@Hafsa-Naeem
Copy link
Contributor

No description provided.

<!-- Only new 3.4 installations need this fix -->
<migration class="PKP\migration\upgrade\v3_4_0\I8592_SiteNotificationSubscriptions"/>
<migration class="APP\migration\upgrade\v3_4_0\I9822_ChangeUsageStatsTemporaryTablesIndexes"/>
<migration class="PKP\migration\upgrade\v3_5_0\I10962_UpdateEmailTemplateVariables"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand it correctly , here upgrading from min 3.1.0.0 to max 3.4.0.1 and upgrading from

  1. 3.3.0-x to 3.5.0-x
  2. 3.4.0-x to 3.5.0-x
  3. 3.5.0-0/3.5.0-1 to 3.5.0-x

will not have this block of migration to run . so do we need it here ? please correct me if I am mistaken .

Comment on lines 100 to 102
<upgrade minversion="3.3.0.0" maxversion="3.4.9.9">
<migration class="PKP\migration\upgrade\v3_5_0\I10962_UpdateEmailTemplateVariables"/>
</upgrade>
Copy link
Member

@touhidurabir touhidurabir Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we any installation upgrading from

  1. 3.3.0-0 to 3.5.0-x
  2. 3.4.0-x to 3.5.0-x

will have this migration applied . So will it work if we move it under the block of <upgrade minversion="3.1.0.0" maxversion="3.4.9.9"> ?

Copy link
Member

@touhidurabir touhidurabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hafsa-Naeem Seems all ok . But I have some concerns regarding to upgrade path and blocks where we applied the migration, please check the comments .

@Hafsa-Naeem Hafsa-Naeem force-pushed the i10962-stable-3_5_0-fix branch from 3f871e6 to b2c181a Compare November 17, 2025 15:09
@Hafsa-Naeem
Copy link
Contributor Author

@touhidurabir Thanks, yes we don’t need a separate 3.3.0.0 - 3.4.9.9 block. To make the intent clear and avoid duplication, I've kept I10962_UpdateEmailTemplateVariables in two places only now:

3.1.0.0 - 3.4.9.9 (covers upgrades from ≤3.4)

3.5.0.0 - 3.5.9.9 (covers 3.5.0-0/3.5.0-1 -> 3.5.x)

This matches what I tested for 3.3.x -> 3.5.x, 3.4.x -> 3.5.x, and 3.5.0-0 -> 3.5.x.

@touhidurabir
Copy link
Member

@Hafsa-Naeem , I have also approved the OMP and OPS PRs .

@Hafsa-Naeem Hafsa-Naeem force-pushed the i10962-stable-3_5_0-fix branch 5 times, most recently from fcd702b to b7b2245 Compare November 28, 2025 19:15
@Hafsa-Naeem Hafsa-Naeem force-pushed the i10962-stable-3_5_0-fix branch from b7b2245 to 9cb395e Compare November 28, 2025 22:29
@Hafsa-Naeem Hafsa-Naeem merged commit 0ffa333 into pkp:stable-3_5_0 Nov 28, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants