-
Notifications
You must be signed in to change notification settings - Fork 148
I10962 stable 3 5 0 fix #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I10962 stable 3 5 0 fix #2163
Conversation
2016052 to
750bc0d
Compare
dbscripts/xml/upgrade.xml
Outdated
| <!-- Only new 3.4 installations need this fix --> | ||
| <migration class="PKP\migration\upgrade\v3_4_0\I8592_SiteNotificationSubscriptions"/> | ||
| <migration class="APP\migration\upgrade\v3_4_0\I9822_ChangeUsageStatsTemporaryTablesIndexes"/> | ||
| <migration class="PKP\migration\upgrade\v3_5_0\I10962_UpdateEmailTemplateVariables"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand it correctly , here upgrading from min 3.1.0.0 to max 3.4.0.1 and upgrading from
3.3.0-xto3.5.0-x3.4.0-xto3.5.0-x3.5.0-0/3.5.0-1to3.5.0-x
will not have this block of migration to run . so do we need it here ? please correct me if I am mistaken .
dbscripts/xml/upgrade.xml
Outdated
| <upgrade minversion="3.3.0.0" maxversion="3.4.9.9"> | ||
| <migration class="PKP\migration\upgrade\v3_5_0\I10962_UpdateEmailTemplateVariables"/> | ||
| </upgrade> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we any installation upgrading from
3.3.0-0to3.5.0-x3.4.0-xto3.5.0-x
will have this migration applied . So will it work if we move it under the block of <upgrade minversion="3.1.0.0" maxversion="3.4.9.9"> ?
touhidurabir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hafsa-Naeem Seems all ok . But I have some concerns regarding to upgrade path and blocks where we applied the migration, please check the comments .
3f871e6 to
b2c181a
Compare
|
@touhidurabir Thanks, yes we don’t need a separate 3.3.0.0 - 3.4.9.9 block. To make the intent clear and avoid duplication, I've kept I10962_UpdateEmailTemplateVariables in two places only now: 3.1.0.0 - 3.4.9.9 (covers upgrades from ≤3.4) 3.5.0.0 - 3.5.9.9 (covers 3.5.0-0/3.5.0-1 -> 3.5.x) This matches what I tested for 3.3.x -> 3.5.x, 3.4.x -> 3.5.x, and 3.5.0-0 -> 3.5.x. |
|
@Hafsa-Naeem , I have also approved the OMP and OPS PRs . |
fcd702b to
b7b2245
Compare
b7b2245 to
9cb395e
Compare
No description provided.