Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkp/pkp-lib#1660 Customizable Reviewer Recommendations #4505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
pkp/pkp-lib#1660 Customizable Reviewer Recommendations #4505
Changes from all commits
5fe55a0
743029a
0b1b989
1b55c28
6b752cb
51c68d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should account for a recommendation not being found, returning a 404 if none is found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RIght , this should get included in
in_array($actionName, ['get', 'edit', 'updateStatus', 'delete'])
. Added it .There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in variable name. Also, if the data is not validated, do we manually need to return a different response here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for
$validateds
? this is intentionally done as plural from ofvalidated
so identify as all validated data .As we are using
FromRequest
asAddReviewerRecommendation
, so any failed validation will be handled there and return back from there without reaching to controller code . Here we will get validated data after successful validation, so no need to return different response as will never reach here without completing the validation successfully .There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, I thought that was probably the case but I didn't know if how we were using it would handle all that automatically.