Install to tmpdir then atomic move #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhheider
reviewed
Feb 8, 2025
crates/lib/src/install.rs
Outdated
| @@ -7,6 +7,7 @@ use tokio_tar::Archive; | |||
|
|
|||
| // Compatibility trait lets us call `compat()` on a futures::io::AsyncRead | |||
| // to convert it into a tokio::io::AsyncRead. | |||
| use tempfile::{self, tempdir_in}; | |||
There was a problem hiding this comment.
Probably shouldn't be between this comment and the following line.
|
The failure seems to be due to the way the But I am struggling to stop it doing it. It’s remarkable consistent when installing |
|
lol it's because semverator renders the openSSL version as 1.1.1.23. My bad when implementing the render function probs. |
mxcl
force-pushed
the
install-to-tmp
branch
3 times, most recently
from
7b5e998 to
1fd2a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1100