Fix when pkgx is installed by Homebrew on Linux #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecrs
commented
Feb 15, 2025
jhheider
reviewed
Feb 16, 2025
Comment on lines
+8
to
+25
| let path = "/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"; | ||
|
|
||
| // for pkgx installed via homebrew | ||
| let homebrewPrefix = ""; | ||
| switch (Deno.build.os) { | ||
| case "darwin": | ||
| homebrewPrefix = "/opt/homebrew"; // /usr/local is already in the path | ||
| break; | ||
| case "linux": | ||
| homebrewPrefix = `/home/linuxbrew/.linuxbrew:${Deno.env.get("HOME")}/.linuxbrew`; | ||
| break; | ||
| } | ||
| if (homebrewPrefix) { | ||
| homebrewPrefix = Deno.env.get("HOMEBREW_PREFIX") ?? homebrewPrefix; | ||
| path = `${homebrewPrefix}/bin:${path}`; | ||
| } | ||
|
|
||
| return path; |
There was a problem hiding this comment.
it would be slower to use fs.exists(), but we could just loop an array of paths and add them if they're there.
There was a problem hiding this comment.
Yeah, but I think it still makes sense to only search on some directories conditionally. For example, it doesn't make sense to search for /home/linuxbrew/.linuxbrew on a macOS.
There was a problem hiding this comment.
that's reasonably correct. if it's present, who knows what it's doing?
mxcl
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.