Add docker support #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker is pretty popular and was even the number 1 most wanted platform in the recent Stack Overflow Developer Survey 2020, hence I thought adding docker support would be a nice addition here.
I've used the alpine variant of the official image for nginx to serve the files, so the resulting container is just 28.1 MB now. I've also added gzip support and shaved down to 156 kb on load. EDIT: on hind sight, I noticed that you bundled the css & js files in your demo site with even smaller footprint at 81.4 kb, so if you can also guide me on what is your current bundling process looks like, it would be great! I can't seem to find the
all2.cssandall.build.jsfiles in this repo.With that said, one thing I would like to ask @pkalogiros is would you mind creating a Docker ID at Docker Hub? It is free for all public repos and 1 private repo of your choice. This is so that the image will be
pkalogiros/audiomassinstead ofazrikahar/audiomass. There is also built in triggers on Docker Hub so once you did the initial setup, it will automatically build a new image every time you push new commits. I'm more than happy to guide you through the process of setting this up. Here is the the image from my forked repo on Docker Hub: https://hub.docker.com/r/azrikahar/audiomass just to give you a general idea of how the end result will be. I will be removing this image once you have yours up and going.