Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issues that were surfaced by the changes in rust 1.70, where misaligned pointer dereferences now cause panics. The issues were two-fold:
bumpalo
we weren't specifying the alignment, so adding the alignment to the layout fixed that.BucketMeta
from the memory mapped data, it's likely that data won't be aligned properly. The fix for this one is to copy the data (16 bytes) to a buffer and then cast it to a*BucketMeta
, which we then dereference and return.Fixes #26