Fix defined or to not force boolean context #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohawk2
force-pushed
the
fix-defined-or
branch
3 times, most recently
from
386cf68 to
723b601
Compare
mohawk2
force-pushed
the
fix-defined-or
branch
from
5c3354f to
7c08e4f
Compare
mohawk2
force-pushed
the
fix-defined-or
branch
2 times, most recently
from
aea92e4 to
03a24c8
Compare
mohawk2
force-pushed
the
fix-defined-or
branch
from
7ae5300 to
1ccc0b0
Compare
mohawk2
force-pushed
the
fix-defined-or
branch
from
61c92e4 to
402db74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
//and//=operations, Devel::Cover was until this PR imposing boolean context. This is usually invisible, but breaks PDL where multi-element ndarrays die if boolean context is imposed, which is wrong if they're being//=instead.This fixes that by adding the notion of "true-ish", which for dor and dorassign is
SvOK, notSvTRUE.By the way, I imitated the style that was there already and usedIn fact I have included this, because the conditional stuff made the#ifdef, but theMakefile.PLhasuse 5.012at the top. Should the metadata have that added too? And would you be happy for me to PR (or you can do it) removing the conditional stuff for < 5.12?DORcode very complicated for no good reason.