deps: Bump Three.js to r151 #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not work yet, there are compatibility breaks around shaders See: #1198
0b5vr
added
bug
0b5vr
commented
May 30, 2023
| @@ -161,7 +171,7 @@ vec3 getDiffuse( | |||
| } | |||
|
|
|||
| void RE_Direct_MToon( const in IncidentLight directLight, const in GeometricContext geometry, const in MToonMaterial material, const in float shadow, inout ReflectedLight reflectedLight ) { | |||
| float dotNL = saturate( dot( geometry.normal, directLight.direction ) ); | |||
| float dotNL = clamp( dot( geometry.normal, directLight.direction ), -1.0, 1.0 ); | |||
There was a problem hiding this comment.
光の当たっていない側にトゥーンのfeatherを動かせられなかったのを修正しました。
|
👍 |
ke456-png
approved these changes
May 31, 2023
Comment on lines
+53
to
+56
| #if THREE_VRM_THREE_REVISION >= 151 | ||
| vUv = uv; | ||
| #else | ||
| vUv = ( uvTransform * vec3( uv, 1 ) ).xy; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will resolve #1198
Description
This PR bumps Three.js to r151.
This PR also fixes shader errors in r151 while maintaining compatibility before r151.
Also added a feature test scene for MToon.
See: https://github.com/mrdoob/three.js/releases/tag/r151
TODO