-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring utils project to use barrel output #9524
Conversation
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/telemetry/errors.spec.ts › can report an indexdb error to telemetry service Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9524 +/- ##
==========================================
+ Coverage 74.24% 75.77% +1.52%
==========================================
Files 1332 1427 +95
Lines 40817 43056 +2239
Branches 7634 7922 +288
==========================================
+ Hits 30306 32626 +2320
+ Misses 10511 10430 -81 ☔ View full report in Codecov by Sentry. |
@fungairino Vercel Storybook job failing with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fungairino see failing Vercel/Storybook job: #9524 (comment)
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
The vercel job failing is just due to output types not being generated. We would just need to run |
What does this PR do?
Future Work
Checklist
N/a
For more information on our expectations for the PR process, see the
code review principles doc