Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring utils project to use barrel output #9524

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

fungairino
Copy link
Collaborator

@fungairino fungairino commented Nov 14, 2024

What does this PR do?

Future Work

  • Install nx/js plugin to handle ts tasks and automate tsconfig references

Checklist

N/a

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

github-actions bot commented Nov 14, 2024

Playwright test results

passed  153 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 14 seconds
commit  fb236a3
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/telemetry/errors.spec.ts › can report an indexdb error to telemetry service

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.77%. Comparing base (8318d74) to head (fb236a3).
Report is 514 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9524      +/-   ##
==========================================
+ Coverage   74.24%   75.77%   +1.52%     
==========================================
  Files        1332     1427      +95     
  Lines       40817    43056    +2239     
  Branches     7634     7922     +288     
==========================================
+ Hits        30306    32626    +2320     
+ Misses      10511    10430      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller
Copy link
Contributor

@fungairino Vercel Storybook job failing with:

SB_BUILDER-WEBPACK5_0002 (WebpackInvocationError): Module not found: Error: Can't resolve '@pixiebrix/util-debug' in './src/pageEditor/store/editor'

@twschiller twschiller self-requested a review November 15, 2024 13:35
Copy link
Contributor

@twschiller twschiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fungairino see failing Vercel/Storybook job: #9524 (comment)

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@fungairino
Copy link
Collaborator Author

The vercel job failing is just due to output types not being generated. We would just need to run npm run build:typecheck

@fungairino fungairino merged commit 42dbf8e into main Nov 15, 2024
25 checks passed
@fungairino fungairino deleted the barrel-utils branch November 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants