Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only upload the dist directory to AWS #9521

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

grahamlangford
Copy link
Collaborator

@grahamlangford grahamlangford commented Nov 13, 2024

What does this PR do?

  • Prevents zipping the full /applications/browser-extension/dist path
  • Fixes Rainforest failures

Discussion

  • Considered pushd and popd instead of cd, but wasn't certain it was guaranteed to be available (sh vs bash)

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (8318d74) to head (32b632a).
Report is 506 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9521      +/-   ##
==========================================
+ Coverage   74.24%   75.79%   +1.54%     
==========================================
  Files        1332     1422      +90     
  Lines       40817    42917    +2100     
  Branches     7634     7902     +268     
==========================================
+ Hits        30306    32530    +2224     
+ Misses      10511    10387     -124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link

github-actions bot commented Nov 13, 2024

Playwright test results

failed  5 failed
passed  147 passed
flaky  2 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  14 minutes, 40 seconds
commit  32b632a
info  For more information on how to debug and view this report, see our readme

Failed tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add new mod with different starter brick components
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add new mod with different starter brick components
chrome › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page
msedge › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page
msedge › tests/runtime/sidebar/sidebarActivation.spec.ts › initiates sidebar mod activation from activate url click

Flaky tests

msedge › tests/extensionConsole/activation.spec.ts › can activate a mod with built-in integration
msedge › tests/pageEditor/modEditorPane.spec.ts › mod editor pane behavior

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@@ -17,5 +17,8 @@ BUILD_FILENAME="${BUILD_PATH##*/}"
: "${AWS_SECRET_ACCESS_KEY?Need to set AWS_SECRET_ACCESS_KEY}"
: "${AWS_DEFAULT_REGION?Need to set AWS_DEFAULT_REGION}"

zip -r "$BUILD_FILENAME" applications/browser-extension/dist -x '*.map'
cd applications/browser-extension
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: leave a comment to indicate why we need to cd into there. (to avoid zipping the nested applications/browser-extension directory structure)

@grahamlangford grahamlangford merged commit f4c2876 into main Nov 13, 2024
13 of 18 checks passed
@grahamlangford grahamlangford deleted the fix-rainforest-upload-directory branch November 13, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants