-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only upload the dist directory to AWS #9521
Conversation
…e uploaded to AWS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9521 +/- ##
==========================================
+ Coverage 74.24% 75.79% +1.54%
==========================================
Files 1332 1422 +90
Lines 40817 42917 +2100
Branches 7634 7902 +268
==========================================
+ Hits 30306 32530 +2224
+ Misses 10511 10387 -124 ☔ View full report in Codecov by Sentry. |
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Playwright test results 5 failed Details Open report ↗︎ Failed testschrome › tests/pageEditor/addStarterBrick.spec.ts › Add new mod with different starter brick components Flaky testsmsedge › tests/extensionConsole/activation.spec.ts › can activate a mod with built-in integration Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
@@ -17,5 +17,8 @@ BUILD_FILENAME="${BUILD_PATH##*/}" | |||
: "${AWS_SECRET_ACCESS_KEY?Need to set AWS_SECRET_ACCESS_KEY}" | |||
: "${AWS_DEFAULT_REGION?Need to set AWS_DEFAULT_REGION}" | |||
|
|||
zip -r "$BUILD_FILENAME" applications/browser-extension/dist -x '*.map' | |||
cd applications/browser-extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: leave a comment to indicate why we need to cd into there. (to avoid zipping the nested applications/browser-extension directory structure)
What does this PR do?
/applications/browser-extension/dist
pathDiscussion
pushd
andpopd
instead ofcd
, but wasn't certain it was guaranteed to be available (sh vs bash)For more information on our expectations for the PR process, see the
code review principles doc