Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop currentModId as a concept #9490

Merged
merged 26 commits into from
Nov 15, 2024

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

  • Refactors to eliminate the need for currentModId
  • No longer set activeModId to null when selecting a modComponentId

Discussion

  • See the InvariantMiddleware

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (8318d74) to head (3b48053).
Report is 511 commits behind head on main.

Files with missing lines Patch % Lines
...geEditor/modListingPanel/modals/CreateModModal.tsx 0.00% 5 Missing ⚠️
...src/pageEditor/hooks/useCreateModFromUnsavedMod.ts 0.00% 2 Missing ⚠️
...ditor/modListingPanel/modals/SaveAsNewModModal.tsx 0.00% 1 Missing ⚠️
...geEditor/store/editor/editorInvariantMiddleware.ts 88.88% 1 Missing ⚠️
...ns/browser-extension/src/store/editorMigrations.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9490      +/-   ##
==========================================
+ Coverage   74.24%   75.79%   +1.54%     
==========================================
  Files        1332     1422      +90     
  Lines       40817    42925    +2108     
  Branches     7634     7908     +274     
==========================================
+ Hits        30306    32534    +2228     
+ Misses      10511    10391     -120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 11, 2024

Playwright test results

passed  153 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 8 seconds
commit  3b48053
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/saveMod.spec.ts › shows error notification when updating a public mod without incrementing the version

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link
Contributor

@twschiller twschiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. I'd prefer a migration: https://github.com/pixiebrix/pixiebrix-extension/pull/9490/files#r1837109301

See failing types job for unused import

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller modified the milestones: 2.2.1, 2.2.0 Nov 11, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, just noticed while debugging

@twschiller twschiller modified the milestones: 2.2.0, 2.2.1 Nov 14, 2024
@grahamlangford grahamlangford merged commit 55db8d3 into main Nov 15, 2024
21 checks passed
@grahamlangford grahamlangford deleted the refactor/drop-unnecessary-editor-state branch November 15, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants