-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop currentModId as a concept #9490
Conversation
…refactor/drop-unnecessary-editor-state
applications/browser-extension/src/pageEditor/store/editor/editorInvariantMiddleware.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9490 +/- ##
==========================================
+ Coverage 74.24% 75.79% +1.54%
==========================================
Files 1332 1422 +90
Lines 40817 42925 +2108
Branches 7634 7908 +274
==========================================
+ Hits 30306 32534 +2228
+ Misses 10511 10391 -120 ☔ View full report in Codecov by Sentry. |
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/pageEditor/saveMod.spec.ts › shows error notification when updating a public mod without incrementing the version Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall. I'd prefer a migration: https://github.com/pixiebrix/pixiebrix-extension/pull/9490/files#r1837109301
See failing types
job for unused import
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
…refactor/drop-unnecessary-editor-state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, just noticed while debugging
…refactor/drop-unnecessary-editor-state
…refactor/drop-unnecessary-editor-state
What does this PR do?
currentModId
activeModId
to null when selecting a modComponentIdDiscussion
For more information on our expectations for the PR process, see the
code review principles doc