Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-shadow-root from 6.1.0 to 6.2.0 #3088

Merged
merged 1 commit into from
May 28, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 4, 2022

Bumps react-shadow-root from 6.1.0 to 6.2.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 4, 2022
@fregante fregante closed this Apr 4, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 4, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/react-shadow-root-6.2.0 branch April 4, 2022 12:19
@fregante
Copy link
Contributor

@dependabot reopen

@dependabot dependabot bot reopened this May 28, 2022
@dependabot dependabot bot restored the dependabot/npm_and_yarn/react-shadow-root-6.2.0 branch May 28, 2022 08:00
Bumps [react-shadow-root](https://github.com/apearce/react-shadow-root) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/apearce/react-shadow-root/releases)
- [Commits](https://github.com/apearce/react-shadow-root/commits)

---
updated-dependencies:
- dependency-name: react-shadow-root
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-shadow-root-6.2.0 branch from 68a1cf3 to 7388ac6 Compare May 28, 2022 08:03
@fregante
Copy link
Contributor

This solves one peer-dependency issue in npm v8, but it won't be enough:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/react
npm WARN   peer react@">=16.3.0" from @emotion/[email protected]
npm WARN   node_modules/@emotion/core
npm WARN     peer @emotion/core@"^10.0.27" from @emotion/[email protected]
npm WARN     node_modules/@emotion/styled
npm WARN     5 more (@emotion/styled-base, @storybook/theming, ...)
npm WARN   96 more (@emotion/react, @emotion/styled, @emotion/styled-base, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^0.14 || ^15.0.0 || ^16.0.0-alpha" from [email protected]
npm WARN node_modules/airbnb-prop-types
npm WARN   airbnb-prop-types@"^2.15.0" from [email protected]
npm WARN   node_modules/react-outside-click-handler
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react
npm WARN   peer react@"^0.14 || ^15.0.0 || ^16.0.0-alpha" from [email protected]
npm WARN   node_modules/airbnb-prop-types
npm WARN     airbnb-prop-types@"^2.15.0" from [email protected]
npm WARN     node_modules/react-outside-click-handler

React 18 is out but these dependencies still don't technically support v17:

By the look of this article, this won't be resolved anytime soon:

https://dev.to/wojtekmaj/enzyme-is-dead-now-what-ekl

Solution: after we upgrade to npm v8, we will have to run every npm install with --force.

Thanks, Obama.

@fregante fregante enabled auto-merge (squash) May 28, 2022 08:09
@fregante fregante requested a review from twschiller May 28, 2022 08:09
@fregante fregante merged commit b10877c into main May 28, 2022
@fregante fregante deleted the dependabot/npm_and_yarn/react-shadow-root-6.2.0 branch May 28, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant