Support stemcell name property #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broadcom has started supporting FIPS enabled stemcells whose version matches the non-FIPS stemcells and without a name specified the FIPS may unintentionally be used when a deployment might not support FIPS. To avoid this allow consumers to set a stemcell name property to point to the expected stemcell name. This allows BOSH to ensure the desired stemcell is always used and not unintentionally deploying with the wrong variant. This commit updates the spec property of the broker job to allow defining the stemcell.name or stemcells[].name property for a data service product. To fully support the name property this depends on changes in the ODB SDK in pivotal-cf/on-demand-services-sdk#200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadcom has started supporting FIPS enabled stemcells whose version matches the non-FIPS stemcells and without a name specified the FIPS may unintentionally be used when a deployment might not support FIPS.
To avoid this allow consumers to set a stemcell name property to point to the expected stemcell name. This allows BOSH to ensure the desired stemcell is always used and not unintentionally deploying with the wrong variant.
This commit updates the spec property of the broker job to allow defining the stemcell.name or stemcells[].name property for a data service product.
To fully support the name property this depends on changes in the ODB SDK in pivotal-cf/on-demand-services-sdk#200