feat: allow client name to be configured

[#finishes #173420890]("https://www.pivotaltracker.com/story/show/173420890")
[#finishes #173420994]("https://www.pivotaltracker.com/story/show/173420994")

jobs/broker/spec

@@ -152,6 +152,7 @@ properties:
  resource_ids: <comma separated list of resource ids>
  authorized_grant_types: <comma separated list of grant types>
  authorities: <comma separated list of authorities>
+ name: <name>
 
  service_instances_api.url:
  description: "service instances API provider URL"

jobs/broker/templates/broker.yml.erb

@@ -393,7 +393,7 @@ def normalise_cf_authentication(cf)
  if cf['uaa']['client_definition'].nil?
  cf['uaa'].delete('client_definition')
  else
- valid_props = %w{scopes authorities authorized_grant_types resource_ids}
+ valid_props = %w{scopes authorities authorized_grant_types resource_ids name}
  cf['uaa']['client_definition'].keys.each do |k|
  raise "Invalid client_definition config - valid properties are: #{valid_props.join(", ")}" unless valid_props.include? k
  end

spec/broker_config_template_spec.rb

@@ -799,6 +799,7 @@
  'resource_ids' => 'some-resource-id',
  'authorized_grant_types' => 'some-authorization',
  'authorities' => 'some-authority,another-authority',
+ 'name' => 'some-name'
  }
  }
 
@@ -825,7 +826,7 @@
  it 'raises an error' do
  expect do
  rendered_template
- end.to raise_error(RuntimeError, 'Invalid client_definition config - valid properties are: scopes, authorities, authorized_grant_types, resource_ids')
+ end.to raise_error(RuntimeError, 'Invalid client_definition config - valid properties are: scopes, authorities, authorized_grant_types, resource_ids, name')
  end
  end