Kiln validate resource type allow list #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajita
added
tas-slingshots
jajita
commented
Aug 12, 2024
…ypes Co-authored-by: Christopher Hunter <[email protected]>
…release_source types Co-authored-by: Ajita Jain <[email protected]>
this is just a nice to have
Co-authored-by: Ajita Jain <[email protected]>
Co-Authored-By: Christopher Hunter <[email protected]>
jajita
force-pushed
the
kiln-validate-resource-type-allow-list
branch
from
1a8d501
to
b000bbe
Compare
|
I just want to confirm that you need to pass all release source types for kiln to validate the file if you pass the new flag.
Meaning, if I just pass one of them, lets say github, should it throw an error that artifactory and bosh.io are not allowed? That's what it is doing now. Please confirm and il merge the PR |
|
@pvaramballypivot Yes, that's right. If the flag is passed and the source type is not in the allow list, it should error out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golden Path requires tile authors to only use artifactory. This new flag allows us to upstream the requirement to Kiln.
This doesn't introduce any breaking changes; new behavior is effectively feature flagged.
Story Id: TPCF-10575