a few internal refactors and added tests #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
crhntr
force-pushed
the
refactors-done-during-all-hands
branch
from
8183d3a
to
7f95c6b
Compare
crhntr
changed the title
crhntr
force-pushed
the
refactors-done-during-all-hands
branch
2 times, most recently
from
7fc89a6
to
5698a7e
Compare
Error: S1017: should replace this `if` statement with an unconditional `strings.TrimPrefix` (gosimple)
crhntr
force-pushed
the
refactors-done-during-all-hands
branch
2 times, most recently
from
09f3734
to
646d55d
Compare
crhntr
force-pushed
the
refactors-done-during-all-hands
branch
from
646d55d
to
53f0cca
Compare
notrepo05
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some test coverage and removes the need to vendor packages in tests.