Skip to content

Commit

Permalink
make commands use pointer reciever
Browse files Browse the repository at this point in the history
  • Loading branch information
crhntr committed Oct 13, 2022
1 parent c62a793 commit a99a7b5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions internal/commands/bake.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ func (b *Bake) loadFlags(args []string, stat flags.StatFunc, readFile func(strin
return nil
}

func (b Bake) Execute(args []string) error {
func (b *Bake) Execute(args []string) error {
err := b.loadFlags(args, os.Stat, os.ReadFile)
if err != nil {
return err
Expand Down Expand Up @@ -371,7 +371,7 @@ func (b Bake) Execute(args []string) error {
return nil
}

func (b Bake) Usage() jhanda.Usage {
func (b *Bake) Usage() jhanda.Usage {
return jhanda.Usage{
Description: "Bakes tile metadata, stemcell, releases, and migrations into a format that can be consumed by OpsManager.",
ShortDescription: "bakes a tile",
Expand Down
10 changes: 5 additions & 5 deletions internal/commands/cache_releases.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (cmd *CacheReleases) WithLogger(logger *log.Logger) *CacheReleases {
return cmd
}

func (cmd CacheReleases) Execute(args []string) error {
func (cmd *CacheReleases) Execute(args []string) error {
_, err := flags.LoadFlagsWithDefaults(&cmd.Options, args, cmd.FS.Stat)
if err != nil {
return err
Expand Down Expand Up @@ -265,7 +265,7 @@ func hasRequiredCompiledPackages(d boshdir.Director, releaseSlug boshdir.Release
return false, nil
}

func (cmd CacheReleases) fetchProductDeploymentData() (_ OpsManagerReleaseCacheSource, deploymentName, stemcellOS, stemcellVersion string, _ error) {
func (cmd *CacheReleases) fetchProductDeploymentData() (_ OpsManagerReleaseCacheSource, deploymentName, stemcellOS, stemcellVersion string, _ error) {
omAPI, err := cmd.OpsManager(cmd.Options.ClientConfiguration)
if err != nil {
return nil, "", "", "", err
Expand Down Expand Up @@ -301,7 +301,7 @@ func (cmd CacheReleases) fetchProductDeploymentData() (_ OpsManagerReleaseCacheS
return omAPI, manifest.Name, stagedStemcell.OS, stagedStemcell.Version, nil
}

func (cmd CacheReleases) cacheRelease(bosh boshdir.Director, rc ReleaseStorage, deployment boshdir.Deployment, releaseSlug boshdir.ReleaseSlug, stemcellSlug boshdir.OSVersionSlug) (component.Lock, error) {
func (cmd *CacheReleases) cacheRelease(bosh boshdir.Director, rc ReleaseStorage, deployment boshdir.Deployment, releaseSlug boshdir.ReleaseSlug, stemcellSlug boshdir.OSVersionSlug) (component.Lock, error) {
cmd.Logger.Printf("\texporting %s\n", releaseSlug)
result, err := deployment.ExportRelease(releaseSlug, stemcellSlug, nil)
if err != nil {
Expand Down Expand Up @@ -393,7 +393,7 @@ func (cmd *CacheReleases) saveReleaseLocally(director boshdir.Director, relDir s
return filePath, sha256sumString, sha1sumString, nil
}

func (cmd CacheReleases) downloadAndComputeSHA(cache component.ReleaseSource, remote cargo.ComponentLock) (string, error) {
func (cmd *CacheReleases) downloadAndComputeSHA(cache component.ReleaseSource, remote cargo.ComponentLock) (string, error) {
if remote.SHA1 != "" {
return remote.SHA1, nil
}
Expand All @@ -417,7 +417,7 @@ func (cmd CacheReleases) downloadAndComputeSHA(cache component.ReleaseSource, re
return comp.SHA1, nil
}

func (cmd CacheReleases) Usage() jhanda.Usage {
func (cmd *CacheReleases) Usage() jhanda.Usage {
return jhanda.Usage{
Description: "Downloads compiled bosh releases from an Tanzu Ops Manager bosh director and then uploads them to a bucket",
ShortDescription: "Cache compiled releases",
Expand Down

0 comments on commit a99a7b5

Please sign in to comment.