Skip to content

Commit

Permalink
fix: always use ptr reciever on CacheCompiledReleases
Browse files Browse the repository at this point in the history
  • Loading branch information
crhntr committed Oct 19, 2022
1 parent 327f2fd commit 309e765
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions internal/commands/cache_compiled_releases.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (cmd *CacheCompiledReleases) WithLogger(logger *log.Logger) *CacheCompiledR
return cmd
}

func (cmd CacheCompiledReleases) Execute(args []string) error {
func (cmd *CacheCompiledReleases) Execute(args []string) error {
_, err := flags.LoadFlagsWithDefaults(&cmd.Options, args, cmd.FS.Stat)
if err != nil {
return err
Expand Down Expand Up @@ -265,7 +265,7 @@ func hasRequiredCompiledPackages(d boshdir.Director, releaseSlug boshdir.Release
return false, nil
}

func (cmd CacheCompiledReleases) fetchProductDeploymentData() (_ OpsManagerReleaseCacheSource, deploymentName, stemcellOS, stemcellVersion string, _ error) {
func (cmd *CacheCompiledReleases) fetchProductDeploymentData() (_ OpsManagerReleaseCacheSource, deploymentName, stemcellOS, stemcellVersion string, _ error) {
omAPI, err := cmd.OpsManager(cmd.Options.ClientConfiguration)
if err != nil {
return nil, "", "", "", err
Expand Down Expand Up @@ -301,7 +301,7 @@ func (cmd CacheCompiledReleases) fetchProductDeploymentData() (_ OpsManagerRelea
return omAPI, manifest.Name, stagedStemcell.OS, stagedStemcell.Version, nil
}

func (cmd CacheCompiledReleases) cacheRelease(bosh boshdir.Director, rc ReleaseStorage, deployment boshdir.Deployment, releaseSlug boshdir.ReleaseSlug, stemcellSlug boshdir.OSVersionSlug) (component.Lock, error) {
func (cmd *CacheCompiledReleases) cacheRelease(bosh boshdir.Director, rc ReleaseStorage, deployment boshdir.Deployment, releaseSlug boshdir.ReleaseSlug, stemcellSlug boshdir.OSVersionSlug) (component.Lock, error) {
cmd.Logger.Printf("\texporting %s\n", releaseSlug)
result, err := deployment.ExportRelease(releaseSlug, stemcellSlug, nil)
if err != nil {
Expand Down Expand Up @@ -393,7 +393,7 @@ func (cmd *CacheCompiledReleases) saveReleaseLocally(director boshdir.Director,
return filePath, sha256sumString, sha1sumString, nil
}

func (cmd CacheCompiledReleases) downloadAndComputeSHA(cache component.ReleaseSource, remote cargo.ComponentLock) (string, error) {
func (cmd *CacheCompiledReleases) downloadAndComputeSHA(cache component.ReleaseSource, remote cargo.ComponentLock) (string, error) {
if remote.SHA1 != "" {
return remote.SHA1, nil
}
Expand All @@ -417,7 +417,7 @@ func (cmd CacheCompiledReleases) downloadAndComputeSHA(cache component.ReleaseSo
return comp.SHA1, nil
}

func (cmd CacheCompiledReleases) Usage() jhanda.Usage {
func (cmd *CacheCompiledReleases) Usage() jhanda.Usage {
return jhanda.Usage{
Description: "Downloads compiled bosh releases from an Tanzu Ops Manager bosh director and then uploads them to a bucket",
ShortDescription: "Cache compiled releases",
Expand Down

0 comments on commit 309e765

Please sign in to comment.