add spnego and basic proxy auth support #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjimoh
requested changes
Dec 5, 2025
sanjimoh
requested changes
Dec 5, 2025
yharish991-brcm
force-pushed
the
add-spnego-proxy-auth-support
branch
from
b0eba8f to
392174c
Compare
mohanakumar
reviewed
Dec 8, 2025
yharish991-brcm
commented
Dec 9, 2025
mohanakumar
reviewed
Dec 9, 2025
yharish991-brcm
force-pushed
the
add-spnego-proxy-auth-support
branch
4 times, most recently
from
5836f6f to
cf0b6a2
Compare
sanjimoh
approved these changes
Dec 10, 2025
mohanakumar
reviewed
Dec 10, 2025
mohanakumar
approved these changes
Dec 10, 2025
mohanakumar
left a comment
mohanakumar
left a comment
There was a problem hiding this comment.
Left couple of minor comments. GTGO with those addressed.
add spnego and basic proxy auth support add NewClientWithProxy for client with proxy authentication
yharish991-brcm
force-pushed
the
add-spnego-proxy-auth-support
branch
from
2376eb8 to
68db4dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proxy authentication(basic, spnego) support to go-pivnet client
Note: i'm currently working on adding tests for this new feature, will push a commit soon..