Skip to content

Bump github.com/shirou/gopsutil and golang.org/x pacakges and fix tests #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ramramu3433
Copy link

@ramramu3433 ramramu3433 commented Jun 13, 2025

This PR addresses new changes related to

  • Dependency update due to go version upgrade
  • Fixes logger dependency in tests
  • removed depreceated integration tests because of https://github.gwd.broadcom.net/TNZ/gormt tool based APIs now used to mutate releases and dependencies

@ramramu3433 ramramu3433 changed the title Bump github.com/shirou/gopsutil and golang.org/x pacakges Bump github.com/shirou/gopsutil and golang.org/x pacakges and fix tests Jun 16, 2025
Copy link
Member

@drich10 drich10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely in the direction we need to go w.r.t removal of create and update capabilities for the pivnet api. Was this intended to cover the full set of removal? If so, there's a large set of functionality that must be removed as well.

err := client.Releases.Delete(testProductSlug, newRelease)
Expect(err).NotTo(HaveOccurred())
})

It("creates, lists, and deletes upgrade path specifiers", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the test descriptions when changing the meaning 😄

task Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the existing test scripts insufficient for something? The name is also not indicative of what the task is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants