Bump github.com/shirou/gopsutil and golang.org/x pacakges and fix tests - #42
Open
ramramu3433 wants to merge 7 commits into
Open
Bump github.com/shirou/gopsutil and golang.org/x pacakges and fix tests#42ramramu3433 wants to merge 7 commits into
ramramu3433 wants to merge 7 commits into
Conversation
ramramu3433
changed the title
ramramu3433
force-pushed
the
upgrade_deps_25
branch
from
June 18, 2025 09:04
a8841c0 to
c1eb789
Compare
ramramu3433
force-pushed
the
upgrade_deps_25
branch
from
June 23, 2025 09:46
949db36 to
c1ca4ee
Compare
drich10
requested changes
Jun 25, 2025
drich10
left a comment
drich10
left a comment
Member
There was a problem hiding this comment.
This is definitely in the direction we need to go w.r.t removal of create and update capabilities for the pivnet api. Was this intended to cover the full set of removal? If so, there's a large set of functionality that must be removed as well.
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
|
|
||
| It("creates, lists, and deletes upgrade path specifiers", func() { |
Member
There was a problem hiding this comment.
We should update the test descriptions when changing the meaning 😄
Member
There was a problem hiding this comment.
Were the existing test scripts insufficient for something? The name is also not indicative of what the task is
ramramu3433
force-pushed
the
upgrade_deps_25
branch
from
June 27, 2025 09:59
c1ca4ee to
a7fc1b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses new changes related to