-
Notifications
You must be signed in to change notification settings - Fork 17
Bump github.com/shirou/gopsutil and golang.org/x pacakges and fix tests #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a8841c0
to
c1eb789
Compare
949db36
to
c1ca4ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely in the direction we need to go w.r.t removal of create and update capabilities for the pivnet api. Was this intended to cover the full set of removal? If so, there's a large set of functionality that must be removed as well.
err := client.Releases.Delete(testProductSlug, newRelease) | ||
Expect(err).NotTo(HaveOccurred()) | ||
}) | ||
|
||
It("creates, lists, and deletes upgrade path specifiers", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the test descriptions when changing the meaning 😄
task
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were the existing test scripts insufficient for something? The name is also not indicative of what the task is
c1ca4ee
to
a7fc1b1
Compare
This PR addresses new changes related to