Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments on page nsxt-3-0-install.html #1346

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

Hyacinthe-Jacquet
Copy link
Contributor

  • Replaced "NSX Manager" with "NSX-T Manager".
  • Removed the redundant part of the login URL.
  • Corrected typos

Which other branches should this be merged with (if any)?
At least some are present since 1.8

- Replaced "NSX Manager" with "NSX-T Manager".
- Removed the redundant part of the login URL.
- Corrected typos
@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@Hyacinthe-Jacquet
Copy link
Contributor Author

Sorry for the multiple commits. I was a bit confused because some issues I found while reading the doc are now already fixed in 1.11 doc, some in 1.10+, but it seems that a lot persist in 1.9. I understand that 1.9 is not maintained.

There are some other varying case used on "Logical Router"/"logical router" and on "Logical Switch"/"logical switch", which I'm not sure if it's intended or an issue.

There's also another issue with the MTU documentation. As far as I know, it is incorrect to state that overlay traffic requires an MTU at 9000. It is recommended to use "1600 or greater" (one page among others: https://docs.vmware.com/en/VMware-NSX-T-Data-Center/3.0/administration/GUID-F7C976EF-2C0D-42D6-ACB5-13453BACD281.html). So the doc should say "1600", not "9000", unless there's an additional requirement for TKGI which should be explained.
Similarly, the statement that "NSX-T Edge Nodes must be connected to a port group that supports > 1600 bytes" is inaccurate, since the MTU should be greater or equals to 1600, not strictly greated to 1600. So > should be replaced by .

@ograves-pivotal ograves-pivotal merged commit 18ebf29 into 1.11 Aug 10, 2021
@Hyacinthe-Jacquet
Copy link
Contributor Author

@ograves-pivotal
I'm not sure if anything should be done about this varying case (maybe it's intended):

There are some other varying case used on "Logical Router"/"logical router" and on "Logical Switch"/"logical switch", which I'm not sure if it's intended or an issue.

But I do think something should be done about the MTU. Do I need to open a separate issue for this?

There's also another issue with the MTU documentation. As far as I know, it is incorrect to state that overlay traffic requires an MTU at 9000. It is recommended to use "1600 or greater" (one page among others: https://docs.vmware.com/en/VMware-NSX-T-Data-Center/3.0/administration/GUID-F7C976EF-2C0D-42D6-ACB5-13453BACD281.html). So the doc should say "1600", not "9000", unless there's an additional requirement for TKGI which should be explained.
Similarly, the statement that "NSX-T Edge Nodes must be connected to a port group that supports > 1600 bytes" is inaccurate, since the MTU should be greater or equals to 1600, not strictly greated to 1600. So > should be replaced by ≥.

@Hyacinthe-Jacquet Hyacinthe-Jacquet deleted the Hyacinthe-Jacquet-patch-4 branch August 12, 2021 14:53
@Hyacinthe-Jacquet
Copy link
Contributor Author

Hyacinthe-Jacquet commented Aug 17, 2021

Logged the MTU point in a separate issue -> #1352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants