fix: adds endpoint to support get-binding response for OSB v2.16 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187886817 The labels on this github issue will be updated when the story is started. |
|
ready to review |
TheSp1der
changed the title
TheSp1der
changed the title
|
Ready for review. Thanks for putting up with my multiple commits to get this to pass checks! |
|
Thanks for raising the PR, we will study and analyse it and we'll come back to you soon. |
FelisiaM
requested changes
Jul 10, 2024
FelisiaM
requested changes
Jul 10, 2024
FelisiaM
approved these changes
Jul 10, 2024
FelisiaM
reviewed
Jul 10, 2024
FelisiaM
approved these changes
Jul 11, 2024
|
Thank you for your contribution @TheSp1der The changes have now been released in v11.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Open Service Broker API defines an endpoint object in the GET Binding Response that is not defined in the brokerapi response. This pull request adds an endpoint struct and updates the GetBindingReponse and GetBindingSpec to properly support the endpoints object.