Fix Date header and add Last-Modified and Content-Disposition headers #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-Modified header implementations
|
Hello, Thanks for the contribution. Could you please add some unit-tests in the corresponding test file ? (headers_test.cc) Other than that, it all looks good to me |
|
I would happily merge this PR if you resolved the merge conflicts and added some simple unit tests. Otherwise, I'll need to close this (we're clearing out unmergable PRs). Thank you very much for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the missing implementation for the Date::write() method, so that it functions, and created new implementation for two additional headers: Last-Modified and Content-Disposition.