Protocol: Keep listener listening if we don't trust the upstream address #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is designed to prevent listeners being stopped when an error is returned, if the upstream connection address is not trusted (
ErrInvalidUpstream
). Instead, we continue to close the connection but now theAccept
method has afor
loop to continue looking for other connections to accept.In using this library we discovered that the listener
Accept
method returning an error caused the listener to be closed and never reopened when trying to serve HTTP endpoints.The change was based on github.com/armon/go-proxyproto/ which does something similar with the loop and checking for a particular type of error.
Notes:
See:
net/http/server.go => Serve(l net.Listener)
https://cs.opensource.google/go/go/+/master:src/net/http/server.go;l=3333-3351
Above we end up returning the
err
at the end, which stops theServe
method (so prevents us listening).