Skip to content

test(app): add unit tests for app package #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Conversation

0xHansLee
Copy link
Contributor

Added unit tests for app package:

  • privkey.go
  • prouter.go

For more improved test coverage, additional integration tests are required for app as done in Omni (ref)

issue: none

@0xHansLee 0xHansLee force-pushed the hans/add-unit-tests-app branch from 2868908 to 35351d5 Compare May 26, 2025 01:19
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@0xHansLee 0xHansLee force-pushed the hans/add-unit-tests-app branch from 35351d5 to cc2c88b Compare May 27, 2025 00:02
Copy link

@ramtinms ramtinms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@0xHansLee 0xHansLee merged commit b9eb011 into main May 27, 2025
14 checks passed
@0xHansLee 0xHansLee deleted the hans/add-unit-tests-app branch May 27, 2025 06:01
Copy link

Binary uploaded successfully 🎉

📦 Version Name: 1.2.1-unstable-b9eb011
📦 Download Source: AWS S3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants