Fix issue with stripTrailing on Java 1.8 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-yuxuan
approved these changes
Mar 16, 2022
piotr-yuxuan
force-pushed
the
g/fix-stripTrailing-java1.8
branch
from
0359914 to
10cb8f7
Compare
|
Thank you very much! |
piotr-yuxuan
added a commit
that referenced
this pull request
Mar 16, 2022
- Thank you @rynkowsg for your valuable contribution: fix issue with stripTrailing on Java 1.8 #21 - Move implementation ns under public API, which could be a breaking change (I don't know how other people use this code) - Use upstream mt/default-value-transformer from malli 0.8.4 - Various minor updates
|
You're welcome :) I love malli and malli-cli sounds like a really good fit. I'm curious how malli-cli works when an app leveraging it is compiled to a native binary with Graal VM. Have you tried that? I will not need it anytime soon, but it would be nice to know that malli-cli is ready to support that. |
|
See:
As |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #20