Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SetReadDeadline and SetWriteDeadline #128

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Conversation

mission-liao
Copy link
Contributor

Description

Allow to set deadline for IO operations.

Reference issue

Fixes #127

@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #128 (dfe9385) into master (444d069) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   74.47%   74.68%   +0.21%     
==========================================
  Files          16       16              
  Lines         709      715       +6     
==========================================
+ Hits          528      534       +6     
  Misses        100      100              
  Partials       81       81              
Flag Coverage Δ
go 74.68% <100.00%> (+0.21%) ⬆️
wasm 74.12% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
session_srtcp.go 76.19% <100.00%> (+0.28%) ⬆️
session_srtp.go 73.80% <100.00%> (+0.31%) ⬆️
stream_srtcp.go 63.26% <100.00%> (+1.56%) ⬆️
stream_srtp.go 69.56% <100.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 444d069...dfe9385. Read the comment docs.

To make the packet I/O of pion/webrtc cancelable without closing
peer-connection, including IO for both RTP and RTCP packets.
@mission-liao
Copy link
Contributor Author

@Sean-Der please feel free to provide any suggestion.

@Sean-Der
Copy link
Member

This PR is perfect! I am so impressed. Fantastic test coverage and everything is well designed, nice work.

Feel free to tag w/e you want! I would do v2.0.0 we just had some churn from context.

@mission-liao mission-liao merged commit 9fa5210 into master Dec 19, 2020
@mission-liao mission-liao deleted the expose-deadline branch December 19, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Expose "SetReadDeadline" and "SetDeadline" from this package
2 participants