CDP-8328: Emit normandie and knox statuses inside pings #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweedeldee
force-pushed
the
jpierre/CDP-8328-errorHandling
branch
from
7ee8844 to
02a0b5f
Compare
Tweedeldee
force-pushed
the
jpierre/CDP-8328-errorHandling
branch
from
02a0b5f to
65f297b
Compare
knguyen100000010
approved these changes
Dec 23, 2024
osoriano
reviewed
Jan 2, 2025
Comment on lines
+23
to
+24
| agentVersion=None, autoscalingGroup=None, availabilityZone=None, ec2Tags=None, stageType=None, | ||
| accountId=None, normandieStatus=None, knoxStatus=None): |
There was a problem hiding this comment.
nit: indentation looks slightly off here
osoriano
reviewed
Jan 2, 2025
| try: | ||
| self._normandie_status = self.get_normandie_status() | ||
| except Exception as e: | ||
| log.exception(f"Failed to get normandie status.: {e}") |
There was a problem hiding this comment.
Suggested change
| log.exception(f"Failed to get normandie status.: {e}") | |
| log.exception(f"Failed to get normandie status: {e}") |
osoriano
reviewed
Jan 2, 2025
| try: | ||
| self._knox_status = self.get_knox_status() | ||
| except Exception as e: | ||
| log.exception(f"Failed to get knox status.: {e}") |
There was a problem hiding this comment.
Suggested change
| log.exception(f"Failed to get knox status.: {e}") | |
| log.exception(f"Failed to get knox status: {e}") |
osoriano
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1759 but with better error handling