[BugFix][Internal] Call StarOsAgent.prepare wherever serviceId is required #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal version of upstream PR StarRocks#54047
Why I'm doing:
I found some edge cases where
StarOsAgent.serviceId
was still empty in the non-leader FE and caused errors when users ranSHOW STORAGE VOLUMES
orSHOW CREATE TABLE
. It turned out thatlistFileStore
andgetFileStore
happen to be missing calls toprepare
which other functions have. I think we need to callprepare
at least once.What I'm doing:
We call
prepare
in all StarOsAgent methods which useserviceId
.Originally I thought this was the wrong approach and tried and reverted the following (see revert commit in history):
1. Removing the call to
StarOsAgent.init
fromGlobalStateMgr.intitialize
. This call is doing nothing since we're calling starOsAgent with a null server and it's overwritten whenStarRocksFE.start
callsStarMgrServer.initialize
soon afterwards.1. This simplifies things by ensuring that we're only calling starOsAgent.init in one place.
2. Having
StarMgrServer
callStarOsAgent.prepare
as soon as it's possible to do so, therefore ensuring thatserviceId
is populated before the agent is used.3. Removing all redundant
prepare
calls from otherStarOsAgent
methods.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: